Re: Incorrect star formation time step criterion in default model of star formation

From: Volker Springel <vspringel_at_MPA-Garching.MPG.DE>
Date: Thu, 8 Jul 2021 16:40:21 +0200

Dear Leonard,

You are right, thanks for pointing this out. The conversion of Sfr back to internal units in this timestep criterion has gone missing in a clean-up attempt of the code, creating a regression. I have fixed this. However, normally this criterion should almost never be active anyhow because the star formation timescale is typically quite long compared to other timescales for the default star formation model.

Best,
Volker

> On 8. Jul 2021, at 13:37, Leonard Romano <leonard.romano_at_tum.de> wrote:
>
>
> Dear gadget-list members,
>
> I noticed that the time step criterion based on the local SFR is essentially never active.
> Digging a bit deeper into the source code I found that the field SFR is stored in units of Msun/yr,
> but for the time step criterion ~ Mgas/SFR the conversion back to code units seems to never be made.
> Maybe I overlooked a conversion back to code units somewhere but if not, I think this should be fixed.
>
> Best,
> Leonard
>
> --
> ===================================================
> Leonard Romano, B.Sc.(レオナルド・ロマノ)
> Physics Department
> Technical University of Munich (TUM), Germany
> Theoretical Astrophysics Group
> Department of Earth and Space Science
> Graduate School of Science, Osaka University, Japan
> he / him / his
> ===================================================
>
>
>
>
> -----------------------------------------------------------
> If you wish to unsubscribe from this mailing, send mail to
> minimalist_at_MPA-Garching.MPG.de with a subject of: unsubscribe gadget-list
> A web-archive of this mailing list is available here:
> http://www.mpa-garching.mpg.de/gadget/gadget-list
Received on 2021-07-08 16:40:23

This archive was generated by hypermail 2.3.0 : 2022-09-01 14:03:43 CEST