Re: Conflict with FOF and Starformation

From: Leonard Romano <leonard.romano_at_tum.de>
Date: Fri, 16 Apr 2021 19:06:12 +0200

Dear Volker,

Thanks for the fix! It solved the problem.

Best,
Leonard

On 15.04.21 14:36, Volker Springel wrote:
> Dear Leonard,
>
> Thanks for pointing out this problem. I agree with your analysis. The fix to simply call domain_rearrange_particle_sequence() can have some problematic side effects in some situations however (it invalidates the SPH neighbor search tree, but this may still be used before its next reconstruction). I think it should be safe to simply do a full domain decomposition before a snapshot/FOF is done when star formation is active.
>
> I have added such thing in lines 525-530 of src/main/run.cc. If this doesn't cure the problem for you, please speak up.
>
> Best,
> Volker
>
>> On 12. Apr 2021, at 18:22, Leonard Romano <leonard.romano_at_tum.de> wrote:
>>
>>
>> Dear Gadget list members,
>>
>> I am running cosmological simulations with star formation and experience crashes whenever gas particles are converted into stars in the same step as a snapshot is written. In particular as soon as "particle_exchange_based_on_PS" is called it crashes with the error "Bummer2".
>> My guess would be that the particle list has not been reordered yet as it would be right before a domain decomposition and so a call to "domain_rearrange_particle_sequence" seems to be missing.
>> I propose promoting "domain_rearrange_particle_sequence" to a public method and calling it right before the I/O in order to avoid similar problems.
>>
>> Best,
>> Leonard
>>
>> --
>> ============================================
>> Leonard Romano, B.Sc.(レオナルド・ロマノ)
>> Physics Department
>> Technical University of Munich (TUM), Germany
>> Theoretical Astrophysics Group
>> Department of Earth and Space Science
>> Graduate School of Science, Osaka University, Japan
>> he / him / his
>> ============================================
>>
>>
>>
>>
>> -----------------------------------------------------------
>> If you wish to unsubscribe from this mailing, send mail to
>> minimalist_at_MPA-Garching.MPG.de with a subject of: unsubscribe gadget-list
>> A web-archive of this mailing list is available here:
>> http://www.mpa-garching.mpg.de/gadget/gadget-list
>
>
>
> -----------------------------------------------------------
>
> If you wish to unsubscribe from this mailing, send mail to
> minimalist_at_MPA-Garching.MPG.de with a subject of: unsubscribe gadget-list
> A web-archive of this mailing list is available here:
> http://www.mpa-garching.mpg.de/gadget/gadget-list

-- 
============================================
Leonard Romano, B.Sc.(レオナルド・ロマノ)
Physics Department
Technical University of Munich (TUM), Germany
Theoretical Astrophysics Group
Department of Earth and Space Science
Graduate School of Science, Osaka University, Japan
he / him / his
============================================
Received on 2021-04-16 19:06:18

This archive was generated by hypermail 2.3.0 : 2022-09-01 14:03:43 CEST