Re: Timer "ngbtreebuild" never called (G4)

From: Volker Springel <vspringel_at_MPA-Garching.MPG.DE>
Date: Sat, 13 Feb 2021 15:27:44 +0100

Hi Leonard,

Thanks for pointing this out. You are right, CPU_NGBTREEBUILD timer and ngbtreebuild were not accumulated anywhere. Unfortunately, a side effect of the templated code Gadget4 uses for the tree construction (which is reused in identical form for gravity tree, neighbour tree, various trees in FOF and Subfind), the ordinary timer for the tree-build measures the times for all these tree constructions together. So it is now slighty involved to pull out the time for the neighbor tree construction as a separate measurement. For the moment, I have therefore removed "ngbtreebuild" as redundant and misleading, and one needs to be aware that "treebuild" measures all tree construction times combined, and not just those related to the gravity tree.

Cheers,
Volker

> On 10. Feb 2021, at 14:51, Leonard Romano <leonard.romano_at_tum.de> wrote:
>
>
> Dear everyone,
>
> I noticed that the timer for the tree construction of the neighbor-tree is never called. Instead upon tree construction the timer "treebuild" associated with "treegrav" timer is called in general for all tree constructions. I think this is misleading (and probably not intended) as it greatly increases the perceived cost associated with gravity and reduces the perceived cost associated with the neighbor-tree.
> This comment isn't really meant as a question, but rather something I wanted to point out, so maybe it doesn't really belong in this mailing list...
>
> Thank you for your attention,
> Leonard
>
> --
> ============================================
> Leonard Romano, B.Sc.(レオナルド・ロマノ)
> Physics Department
> Technical University of Munich (TUM), Germany
> Theoretical Astrophysics Group
> Department of Earth and Space Science
> Graduate School of Science, Osaka University, Japan
> he / him / his
> ============================================
>
>
>
>
> -----------------------------------------------------------
> If you wish to unsubscribe from this mailing, send mail to
> minimalist_at_MPA-Garching.MPG.de with a subject of: unsubscribe gadget-list
> A web-archive of this mailing list is available here:
> http://www.mpa-garching.mpg.de/gadget/gadget-list
Received on 2021-02-13 15:27:45

This archive was generated by hypermail 2.3.0 : 2022-09-01 14:03:43 CEST