Hi Leonard,
> On 11. Aug 2021, at 11:52, Leonard Romano <leonard.romano_at_tum.de> wrote:
>
>
> Dear Volker,
>
> Thank you for your detailed answer. I agree with you that the estimate of the decay timescale is probably fine and also that the latter issue with the possible spurious evolution of Alpha would be more severe.
> However I just checked out your fix and I think the place where you moved the evolution of Alpha to, doesn't seem correct either. In particular, now Alpha would only be advanced for particles where the lower and upper bound for Hsml in the Newton-Raphson iteration are converging, but this completely leaves out the case where the effective number of neighbors is simply within the desired range (which one might hope should be the case for most particles).
> Maybe a suitable place for this would be in the function compute_densities() after the density computation has finished with another loop over active particles, instead.
>
I fully agree - thanks for pointing this out. I have made this change too hastily. I also think that making this call in a separate loop is ultimately best and more transparent. I have changed it accordingly.
Regards,
Volker
> cheers,
> Leonard
>
> On 10.08.21 19:48, Volker Springel wrote:
>> Hi Leonard,
>>
>>> On 26. Jul 2021, at 22:04, Leonard Romano <leonard.romano_at_tum.de> wrote:
>>>
>>> Dear gadget-list members,
>>>
>>> I noticed some possibly major issues with the current implementation of time-dependent artificial viscosity:
>>>
>>> • The decay velocity is computed during the density loop, using Csnd even though Csnd depends on the density that is still to be computed
>> Right, the decay velocity is estimated using the sound-speeds of the particles from their previous timesteps (the sound-speed is set during initialization, so Csnd is always available before the first viscous forces are computed). This should be fine, I think, and was deliberate at this place, as one only needs an approximate estimate for a reasonable decay timescale, and the viscosity and its evolution is associated with dissipative/irreversible processes.
>>
>>> • Alpha is integrated during the density loop, which in particular means that it will be integrated in time as many times as loops are necessary to reach a good density estimate. I think that this should be moved somewhere outside the density loop to ensure correct synchronization.
>> I agree with this. I have moved the corresponding call so that a potential spurious evolution of alpha due to repetitions of the density calculation is avoided. The latter would make the viscosity reach the target viscosity somewhat faster than intended.
>>
>>> I am worried that with these issues, it might not work as intended. I suggest for the decay velocity to compute it during the force loop and integrating Alpha during the kick operations.
>> This would certainly be another possibility, but I'm not sure this would make any appreciable difference in practice. Note that the target viscosity jumps discontinuously in time due to the shock indicator, so integrating alpha smoothly in time is arguably less important than responding quickly when the shock indicator triggers. The idea of the present formulation is that in case this happens, the subsequent kick can immediately apply a higher alpha without having to ramp it up first over the timestep of the kick.
>>
>> In general, there is unfortunately a high degree of arbitrariness in how one evolves (and more generally parameterizes) the artificial viscosity, i.e. there is no perfectly right way of doing it, and one mostly has to rely on test results to establish what works better or worse in practice.
>>
>> Cheers,
>> Volker
>>
>>> Best,
>>> Leonard
>>>
>>> --
>>> ===================================================
>>> Leonard Romano, B.Sc.（レオナルド・ロマノ）
>>> Physics Department
>>> Technical University of Munich (TUM), Germany
>>> Theoretical Astrophysics Group
>>> Department of Earth and Space Science
>>> Graduate School of Science, Osaka University, Japan
>>> he / him / his
>>> ===================================================
>>>
>>>
>>> -----------------------------------------------------------
>>>
>>> If you wish to unsubscribe from this mailing, send mail to
>>> minimalist_at_MPA-Garching.MPG.de with a subject of: unsubscribe gadget-list
>>> A web-archive of this mailing list is available here:
>>> http://www.mpa-garching.mpg.de/gadget/gadget-list
>>
>>
>>
>> -----------------------------------------------------------
>>
>> If you wish to unsubscribe from this mailing, send mail to
>> minimalist_at_MPA-Garching.MPG.de with a subject of: unsubscribe gadget-list
>> A web-archive of this mailing list is available here:
>> http://www.mpa-garching.mpg.de/gadget/gadget-list
>
> --
> ===================================================
> Leonard Romano, B.Sc.（レオナルド・ロマノ）
> Physics Department
> Technical University of Munich (TUM), Germany
> Theoretical Astrophysics Group
> Department of Earth and Space Science
> Graduate School of Science, Osaka University, Japan
> he / him / his
> ===================================================
>
>
>
>
> -----------------------------------------------------------
> If you wish to unsubscribe from this mailing, send mail to
> minimalist_at_MPA-Garching.MPG.de with a subject of: unsubscribe gadget-list
> A web-archive of this mailing list is available here:
> http://www.mpa-garching.mpg.de/gadget/gadget-list
Received on 2021-08-11 12:30:02